Open
Conversation
Member
|
Hey @taingalls ! Thank you very much for your contribution here. It's a really nice feature to add to the server! Two small things:
Also, tested locally and it connects to the app after register flawlessly! |
Author
|
The signup API that I based websignup on is designed to be used as a back end API and that is why the JSON is returned instead of a page. I also had a similar type of response when signup was successful. I don't know if I feel comfortable with javascript to add another page, but I will at least try to make the error message more human readable. |
789218d to
6553f77
Compare
6553f77 to
f26ff86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Allows users to be able to signup for a Ferdium account through a web page in addition to the in-app signup.